search

Brightspace / rules_csharp

Bazel rules for C#
Apache License 2.0
8 stars 5 forks source link

Add support for netcoreapp3.1 #139

Closed j3parker closed 4 years ago

j3parker commented 4 years ago

FYI @jimevans

omsmith commented 4 years ago 
diff --git a/examples/every_framework_empty/BUILD b/examples/every_framework_empty/BUILD
index 5436def..922aded 100644
--- a/examples/every_framework_empty/BUILD
+++ b/examples/every_framework_empty/BUILD
@@ -78,6 +78,11 @@ csharp_library(
     target_frameworks = ["netcoreapp3.0"],
 )

+csharp_library(
+    name = "netcoreapp3.1",
+    target_frameworks = ["netcoreapp3.1"],
+)
+
 csharp_library(
     name = "netstandard2.0",
     target_frameworks = ["netstandard2.0"],
j3parker commented 4 years ago

Could theoretically update the target of import_nuget_package example as well, but 🤷.

Ah yeah, meh. 🤷

I'm assuming 3.1 didn't add any new assemblies.

Yep -- no new assemblies.