Brightspace / rules_csharp

Bazel rules for C#
Apache License 2.0
8 stars 5 forks source link

Add support for .NET 5 #145

Closed jimevans closed 3 years ago

jimevans commented 3 years ago

.NET 5 has officially been released now. These rules should support it.

j3parker commented 3 years ago

Related: issue https://github.com/Brightspace/rules_csharp/issues/141 we need to better document how to do this (it links to the diff of the last time we did).

The BUILD file for the framework (which imports the framework DLLs with the correct dependencies) needs to be regenerated. Unsurprisingly, the list of DLLs has changed:

$ comm -3 <(cd net5.0; ls *.dll) <(cd netcoreapp3.1; ls *.dll)
System.Formats.Asn1.dll
System.Net.Http.Json.dll
        System.Runtime.InteropServices.WindowsRuntime.dll
j3parker commented 3 years ago

(I'll try to get to this today or tomorrow.)