search

Brightspace / rules_csharp

Bazel rules for C#
Apache License 2.0
8 stars 5 forks source link

Do assembly name stuff right #154

Open j3parker opened 3 years ago

j3parker commented 3 years ago

Currently we choose the assembly name based on the target name.

I wouldn't be surprised if we needed to support overriding this in the future. I don't know of a need right now, but I'm opening the issue to acknowledge it and record some thoughts.

If we do we should add the name to the CSharpAssembly provider and scour for usages of ctx.attr.name. In particular, in #153 I started passing the name around to a bunch of helper methods to implement the irefout vs. prefout stuff... that would need to be tidied up,

jimevans commented 3 years ago

Doesn’t the out attribute already do this?

j3parker commented 3 years ago

🤦 you're right, which means that my stuff in #153 has a bug