Brightspace / rules_csharp

Bazel rules for C#
Apache License 2.0
8 stars 5 forks source link

Set up deps inside .NET Framework DLLs correctly #19

Closed j3parker closed 5 years ago

j3parker commented 5 years ago

Our framework build files (like net472.BUILD) don't have dependencies set up correctly. They were hacked up a bit to avoid telling Bazel about .NET Framework's circular dependencies.

We need to fix this. I know how to do it I just haven't had time to sit down and fix the generator.

We will break the cycles in deps, but create alias targets.

For example, @net472//:System.Xml will depend on @net472//:System.Data.SqlXml-somesuffixhere, but @net472//:System.Data.SqlXml-somesuffixhere won't dep on @net472//:System.Xml (even though it does in a CLR sense). We will do alias("System.Data.SqlXml", actual = ":System.Xml") so that when you dep on @net472//:System.Data.SqlXml all the right things happen.