US147082 cleanup Audio Video Editing

[shaz3696]

Relevant Rally Links US147082 Description Acceptance Criteria:

Clean-up code to stop looking for the feature flag and only use the TRUE behaviour

Remove the FALSE behaviour

Remove the Feature Flag

Flag in question: https://github.com/Brightspace/lms-launch-darkly-flags/blob/master/features/activities/face/content/content-audio-video-advanced-editing.feature.json

Goal/Solution

[github-actions[bot]]

PR Checklist:

Did you use a semver keyword in a commit message?

• [ ] Yes I used one in at least one of my commits
• [ ] No but I will use a semver keyword in the commit message when I merge and squash

Did you paste the Rally US URL in the description?

• [ ] Yes
• [ ] No as there's no corresponding Rally US

[shaz3696]

I would review the rally ticket and reach out to its creators for more clarification.

The rally ticket only references content-audio-video-advanced-editing. This flag is used when computing isAdvancedEditingEnabled, but it is not the only factor in computing that property.

Based on my understanding of the ticket, you should be removing references to the flag when computing isAdvancedEditingAvailable in the LMS, which your LMS PR does, but we don't need to remove isAdvancedEditingAvailable or isAdvancedEditingEnabled from siren or activities, as these fields still have meaning without the LaunchDarkly flag.

Can you please confirm on this

[rchaudhary-d2l]

As per suggestions by Gurpinder and Kiefer, this PR is not needed so closing it.