Fix shouldUpdate - Githubissues

BrightspaceHypermediaComponents / siren-sdk

This contains tools to help develop and use siren entities.

Apache License 2.0

2 stars 2 forks source link

Fix shouldUpdate #744

Closed awikkerink closed 1 week ago

awikkerink commented 1 week ago

Change caused unit test failures here: https://github.com/Brightspace/d2l-rubric/pull/3352

github-actions[bot] commented 1 week ago

PR Checklist:

Did you use a semver keyword in a commit message?

[x] Yes I used one in at least one of my commits
[ ] No but I will use a semver keyword in the commit message when I merge and squash

Did you paste the Jira ticket URL in the description?

[ ] Yes
[x] No as there's no corresponding Jira ticket

d2l-github-release-tokens[bot] commented 1 week ago

:tada: This PR is included in version 3.11.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

awikkerink commented 1 week ago

I'm not sure how this would have been causing failures. I guess the example for shouldUpdate in lit docs doesn't extend the superclass either

I'm not sure either. I think since shouldUpdate returns true by default and then the LitElement class checks if the shouldUpdate method has been overridden. Not sure how to deal with shouldUpdate in mixins then...