BrightspaceUI / table

Polymer-based web component for D2L tables
Apache License 2.0
3 stars 12 forks source link

Scroll actions rendered in the wrong position in Edge 16 with RTL #159

Open ppaskaris-d2l opened 6 years ago

ppaskaris-d2l commented 6 years ago

In Microsoft Edge 16, in RTL, the sticky scroll actions are rendered in the wrong position. Specifically, they are rendered far to the right. The click targets are still positioned in the correct place, and the buttons do work as if they were rendered in the correct place.

<d2l-offscreen> is likely causing the issue to manifest:

Microsoft is aware of this issue and it appears to be a defect in their position: sticky; implementation.

awikkerink commented 6 years ago

scroll-wrapper right-action

awikkerink commented 6 years ago

@ppaskaris-d2l Thanks for doing this!

ppaskaris-d2l commented 6 years ago

My pleasure! Sorry it was so rough for me to get the PR up to spec: it was basically a crash course in Daylight development.

Does this need to get release tagged before it can be added to BSI? I've a build locally just against the sha1 and it's beautiful.

awikkerink commented 6 years ago

Yes. You can bump it with npm version minor -m '(chore) bump version %s'

--edit But you don't have access to the repo? I can bump it.

ppaskaris-d2l commented 6 years ago

I sure do not have access. Also, given that this is a bower package, isn't the version just a git-tag?

awikkerink commented 6 years ago

It is, but npm version also updates the package.json. I suppose it technically doesn't matter.

--edit nvm. We aren't using the version in package.json. I must be thinking of another project. I'll bump the git tag