Open ppaskaris-d2l opened 6 years ago
@ppaskaris-d2l Thanks for doing this!
My pleasure! Sorry it was so rough for me to get the PR up to spec: it was basically a crash course in Daylight development.
Does this need to get release tagged before it can be added to BSI? I've a build locally just against the sha1 and it's beautiful.
Yes. You can bump it with npm version minor -m '(chore) bump version %s'
--edit But you don't have access to the repo? I can bump it.
I sure do not have access. Also, given that this is a bower package, isn't the version just a git-tag?
It is, but npm version
also updates the package.json. I suppose it technically doesn't matter.
--edit nvm. We aren't using the version in package.json. I must be thinking of another project. I'll bump the git tag
In Microsoft Edge 16, in RTL, the sticky scroll actions are rendered in the wrong position. Specifically, they are rendered far to the right. The click targets are still positioned in the correct place, and the buttons do work as if they were rendered in the correct place.
<d2l-offscreen>
is likely causing the issue to manifest:Microsoft is aware of this issue and it appears to be a defect in their
position: sticky;
implementation.