BrightspaceUI / text-input

Polymer-based web component for D2L text inputs
http://ui.developers.brightspace.com
Apache License 2.0
0 stars 5 forks source link

Shared styles #10

Closed ianmclean2011 closed 7 years ago

ianmclean2011 commented 7 years ago

Two things I want to point out: 1) The issue with font-family: inherit (just want to make sure that the comment is sufficient, and that how I'm handling it is okay) 2) I think the d2l-typography-shared-styles.html link is unnecessary for both the main d2l-text-input.html file, and the shared styles file ... just want to confirm that is correct (I can make the change to remove if that is the case)

ianmclean2011 commented 7 years ago

It looks like I can use a mixin in a mixin. I moved the --d2l-input-disabled-hover into --d2l-input, and it seems to work fine (I inspected the element, and can see the extra styles being added). Also removed the typography shared styles, and moved typography to the dev-dependencies. Everything seems to look and behave the same in the demo, so it looks good.