search

BrightspaceUI / text-input

Polymer-based web component for D2L text inputs
http://ui.developers.brightspace.com
Apache License 2.0
0 stars 5 forks source link

Mbayly/delegate focus event to behaviour #13

Closed mdgbayly closed 6 years ago

mdgbayly commented 6 years ago

I wonder if we should actually just be doing a major version bump here on d2l-polymer-behaviors-ui and d2l-text-input?

Here, I've made it explicit that this version of d2l-text-input depends on versions >= 1.4.0 of d2l-polymer-behaviors, in an attempt to stop people using this version of d2l-text-input with an earlier version of d2l-polymer-behaviors. But it would still be possible for someone to use the previous version of d2l-text-input with v1.4.0 of d2l-polymer-behaviors-ui and they'd get the double events.

But I'm good with the minor bump too.

Because of the more explicit dependency, the build for this PR will fail until we merge/bump d2l-polymer-behaviors-ui. https://github.com/Brightspace/d2l-polymer-behaviors-ui/pull/19 (I don't have write permissions in that repo)

dlockhart commented 6 years ago

Could you remove the "focus management" tests, since they're essentially duplicated now?