search

BrightspaceUI / text-input

Polymer-based web component for D2L text inputs
http://ui.developers.brightspace.com
Apache License 2.0
0 stars 5 forks source link

Set position of input to relative #17

Closed mdulat closed 6 years ago

mdulat commented 6 years ago

We were having issues with the text-input in rubrics creation. When we added the opt-in/out flyout, the user could not click into the text-input (the flyout has 100% height so can be fully viewed in open position). The other input components did not have this problem (textarea, button), and the difference was the relative positioning of those components. See https://github.com/BrightspaceUI/textarea/blob/master/d2l-textarea.html#L73 and https://github.com/BrightspaceUI/button/blob/aebdda306fe02b6ee87302e804f9eb6aac1998fd/d2l-button-icon.html#L39 Setting position of input element to relative solves this problem.

Besides rubrics, it looks like d2l-text-input is currently being used in: d2l-content-service/app/content/features/purge/ d2l-content-service/app/content/features/search/ course-image-manager/src/course-image-manager-app/views/ But I'm not sure what these are, where to access and test them. Do you guys know?

mdulat commented 6 years ago

Looks like CI tests are failing due to timeouts on Safari. Anyone know what this is about?

wongvincent commented 6 years ago

Was having Safari saucelabs issues as well in another repo. Re-running the build fixed it. Safari on Sauce seems flaky..

ryantmer commented 6 years ago

Updating https://github.com/BrightspaceUI/text-input/blob/master/wct.conf.json to use OSX 10.13 might help as well - there are some issues with 10.12 now, unfortunately.