search

BrightspaceUILabs / file-uploader

Polymer-based web component for D2L file uploader
Apache License 2.0
4 stars 6 forks source link

switching to use d2l-localize-behavior #54

Closed dlockhart closed 7 years ago

dlockhart commented 7 years ago

I've switched this over to use d2l-localize-behavior from app-localize-behavior.

The main change here is that specifying <d2l-file-uploader language="whatever"> is no longer needed -- it will automatically pull the language off the <html lang="fr"> element/attribute. So a much more scalable way to do localization in our web components.

I feel like this should result in a major version bump for the component, since it's changing the way localization is specified.

dlockhart commented 7 years ago

@ryantmer mentioned offline that it might be nice to try and keep the separate file for just the translations. I'm going to play with a setup that preserves this.

dlockhart commented 7 years ago

OK, updated to still use the existing mixin, so the translations can be encapsulated nicely in a separate file.