search

BrightspaceUILabs / file-uploader

Polymer-based web component for D2L file uploader
Apache License 2.0
4 stars 6 forks source link

Support a visible label in addition to offscreen #85

Open dlockhart opened 3 years ago

dlockhart commented 3 years ago

All of our input components support a label attribute and a label-hidden boolean attribute to hide it. This component only has a label attribute, but it's always hidden.

To align this component with the others, a label-hidden attribute should be added and the label should be made visible by default. The styles for the label can be imported from core.

Example of <d2l-input-text>'s label: https://github.com/BrightspaceUI/core/blob/master/components/inputs/input-text.js#L320

Since this will be a breaking change, a code search should be performed to find the places using the uploader (currently only 2) and switch them to specify the label-hidden attribute.