search

Briles / gruvbox-atom

Atom syntax themes with pastel 'retro groove' colors
https://atom.io/themes/gruvbox-plus-syntax
MIT License
35 stars 4 forks source link

Settings text input is unreadable when using "dark" brightness and light UI theme #5

Open int3h opened 8 years ago

int3h commented 8 years ago

There's a bug in Gruvbox Plus that causes <text> boxes in Atom's settings windows, search bar, etc., to be unreadable when using a light UI theme (e.g., "One Light") and Gruvbox Plus' "Brightness" setting is set to "Dark".

See screenshot using the "One Light" UI theme that comes with Atom, and Grubox Plus set to "dark" brightness, "hard" contrast, and "no dimmed colors" variant:

screen shot 2016-06-14 at 1 32 44 pm

The cause seems to be that Atom uses 'mini' text-editor controls for settings, et al. <text> input boxes. When Gruvbox Plus is set to "dark", it uses a light color for default text. On normal text-editors, this is fine, because Gruvbox Plus also sets a dark background color. However, on mini text-editors, Atom uses the UI theme's background color, which can be light. This leads to unreadable light text on a light background.

Atom version: 1.9.0-beta0 Gruvbox Plus version: 1.2.3 OS: Mac OS X "El Capitan" v10.11.5

Briles commented 8 years ago

Thanks for reporting this!

I've added dc1c593590aba54c37dea2558a29f5975c6c31fa and published v1.2.4 which makes the UI theme handle coloring the text input color (regex find/replace colors remain unchanged). This should allow any Gruvbox syntax to be used with any UI theme.

I'm going to leave this issue open while I investigate further in hopes of providing a more robust solution.