Add support for the Skins package, update icons and move gulp src folder

Briles / gruvbox

🎨 Sublime Text themes & color schemes with pastel 'retro groove' colors

MIT License

272 stars 8 forks source link

Add support for the Skins package, update icons and move gulp src folder #26

Closed jrappen closed 7 years ago

jrappen commented 7 years ago

add support for the Skins package by @deathaxe (Briles/gruvbox@939b91e)
fix #14 (Briles/gruvbox@e85a41e)

As I'm not too familiar with gulp, I did not include the *.svg source files and the *.svg to *.png build process from ihodev/sublime-file-icons.

jrappen commented 7 years ago

ping @Briles

Briles commented 7 years ago

My apologies for not reviewing this sooner. I'll try and find some time in the next few days to review your contributions. Thanks!

jrappen commented 7 years ago

Take your time, just pinged you as a reminder 👍

Briles commented 7 years ago

👍 for skins support 👍 for the minimap fix

In regards to the file icons support:

Instead of overriding the Gruvbox file icons with the zz File Icons in the repo, it would be better to add support for the zz File Icons package and keep the original Gruvbox file icons. Those with the zz File Icons package installed will have the ability to override the icons if wanted.

jrappen commented 7 years ago

@Briles Ok, I'll redo this PR with the following changes only:

moving gulp src files from src to .gulp
- while updating references
- while updating docs
- while fixing test references
add Skins package support
fix #24
rename icon prefs output folder to metadata as they are TextMate metadata files
add st-file-icons support

What about the functionality of:

update / installation / removal messages in status bar?
opening the README and a CHANGELOG (merging the messages into one file should do?) via mdpopups in a phantom?

Compare jrappen/sublime-wkhtmltopdf/src/documentation.py

Let me know what you want and I'll re-open later today.

Briles commented 7 years ago

Sounds good! Feel free to add status bar messages & readme & changelog popups. If possible, I would like to give the readme & changelog their own commands & popups, instead of merging into a single file.

Thanks again!

jrappen commented 7 years ago

@Briles I wasn't going to merge the README and CHANGELOG. I meant to merge the files in the messages directory into the new CHANGELOG file. Will do it later today. Closing this for now.