Briles / gruvbox

🎨 Sublime Text themes & color schemes with pastel 'retro groove' colors
MIT License
272 stars 8 forks source link

Selection in dark colour schemes are hard to find #52

Open ghost opened 5 years ago

ghost commented 5 years ago

Selection in dark colour schemes are hard to find

Please consider changing the colour.

gruvbox (dark) (hard): 1

gruvbox (dark) (medium): 2

gruvbox (dark) (soft): 3

Environment

gruvbox:

* version: 4.0.1
* installed via Package Control: True

Sublime Text:

* channel: stable
* version: 3207
* platform: linux
* architecture: x64

Dependency versions:

* mdpopups: Version could not be acquired!
* markdown: 2.6.11
* pygments: 2.1a0
* jinja2: 2.8
abdcdd commented 4 years ago

I'm facing the same issue (especially when having selected multiple same words and want to have an idea of where they are by peeking minimap) and it'd be really great if gruvbox can have an option to adjust selected text foreground/background color! Currently I'm working this around by using PackageResourceViewer to edit gruvbox color scheme by changing: "selection": "var(bg1)", to "selection": "var(red)", but there doesn't seem to be an option to edit selected foreground color so now selected texts are now in their original color with a red background, which seems a little emmmmmm funny :D

Briles commented 3 years ago

I'll look into improving the visibility of the selection background. It's tricky to find a highlight color that is easily distinguishable in a sea of syntax-highlighted code, the highlighted foreground included.

In the meantime, there's always the option of customizing the color theme to your liking. Assuming you don't already have any customizations, you can add a Packages/User/gruvbox (Dark) (Medium).sublime-color-scheme file (but replace the file name with the same one as the scheme you're currently using) with something like this to customize the selection styling:

{
    "globals":
    {
        // The background color of selected text
        "selection": "hsl(70, 0%, 15%)",
        // A color that will override the scope-based text color of the selection
        "selection_foreground": "hsl(70, 0%, 15%)"
    }
}
BarbzYHOOL commented 2 years ago

in another color scheme I did

    "globals":
    {
        "selection": "darkslategrey",
    },