Briles / gruvbox

🎨 Sublime Text themes & color schemes with pastel 'retro groove' colors
MIT License
272 stars 8 forks source link

Added some rules to Atom version #7

Closed smlombardi closed 8 years ago

smlombardi commented 8 years ago

I'm not sure you're aware, but I have ported your excellent theme to Atom a while back. I just rolled your latest additions into the Atom version, and while using it I noticed a few scss rules that I felt were missing, so I added the following, trying to keep the look similar to the theme:

.meta.at-rule.mixin.scss .entity.name.function.scss {
  color: #fe8019;
}

.meta.at-rule.mixin.scss .keyword.control.at-rule.mixin.scss {
  color: #fb4934;
}
.keyword.control.at-rule.mixin.scss .punctuation.definition.keyword.scss {
  color: #cc421d;
}

.meta.at-rule.else.scss .keyword.control.else.scss, .meta.at-rule.if.scss .keyword.control.if.scss {
  color:#fabd2f;
}
.keyword.control.else.scss .punctuation.definition.keyword.scss, .keyword.control.if.scss .punctuation.definition.keyword.scss {
  color: #d79921;
}

.meta.at-rule.return.scss .keyword.control.return.scss {
  color: #fe8019;
}
.keyword.control.return.scss .punctuation.definition.keyword.scss {
  color: #d65d0e;
}

.meta.at-rule.media.scss .keyword.control.at-rule.media.scss {
  color: #689d6a;
}
.keyword.control.at-rule.media.scss .punctuation.definition.keyword.scss {
  color: #8ec07c;
}
.meta.content.scss .keyword.control.content.scss {
  color: #d5c4a1;
  font-style: italic;
}

Should these items be colored differently, in your opinion?

Briles commented 8 years ago

I've edited your code to match the Sublime Text color scheme.

In summary, all at-rules are colored red / #fb4934 with their punctuation colored neutral red / #cc241d. They are colored similarly because they are related; however, you are free to color them as you see fit.

It's important to think about the context in which the scopes will be used. For example:

You have @if & @else colored yellow which may make scanning code harder because class selectors are also colored yellow. In code with many class selectors, these at-rules may become harder to discern.

 .meta.at-rule.mixin.scss .entity.name.function.scss {
-  color: #fe8019;
+  color: #b8bb26;
 }

 .meta.at-rule.mixin.scss .keyword.control.at-rule.mixin.scss {
   color: #fb4934;
 }
 .keyword.control.at-rule.mixin.scss .punctuation.definition.keyword.scss {
-  color: #cc421d;
+  color: #cc241d;
 }

 .meta.at-rule.else.scss .keyword.control.else.scss, .meta.at-rule.if.scss .keyword.control.if.scss {
-  color: #fabd2f;
+  color: #fb4934;
 }
 .keyword.control.else.scss .punctuation.definition.keyword.scss, .keyword.control.if.scss .punctuation.definition.keyword.scss {
-  color: #d79921;
+  color: #cc241d;
 }

 .meta.at-rule.return.scss .keyword.control.return.scss {
-  color: #fe8019;
+  color: #fb4934;
 }
 .keyword.control.return.scss .punctuation.definition.keyword.scss {
-  color: #d65d0e;
+  color: #cc241d;
 }

 .meta.at-rule.media.scss .keyword.control.at-rule.media.scss {
-  color: #689d6a;
+  color: #fb4934;
 }
 .keyword.control.at-rule.media.scss .punctuation.definition.keyword.scss {
-  color: #8ec07c;
+  color: #cc241d;
 }
 .meta.content.scss .keyword.control.content.scss {
-  color: #d5c4a1;
-  font-style: italic;
+  color: #fb4934;
 }
smlombardi commented 8 years ago

Makes sense. I changed a few back. I still prefer calling out the control statements, though. Also, for some reason the media queries are not colored at all on my Sublime install (on the right, below)

screen shot 2016-04-11 at 4 37 38 pm

Briles commented 8 years ago

Yes, the media queries are not scoped in Sublime Text, so I am unable to color them. It's unfortunate, but unless someone makes a better SCSS/SASS syntax, there is not anything I can do.

smlombardi commented 8 years ago

ok, sure. just wanted to call attention to it.

I'm also trying to add some colors to the Atom theme for Typescript (.ts) files and Angular JS HTML files.