search

Brille24 / SyliusCustomOptionsPlugin

A Sylius plugin that adds customer options
MIT License
46 stars 34 forks source link

Add compatibility Sylius 1.11 #109

Closed xaviermarchegay closed 2 years ago

xaviermarchegay commented 2 years ago

Add the compatibility with Sylius 1.11

mamazu commented 2 years ago

Looks like we need to update the github configuration from the base repository. It seems that the node version has changed.

xaviermarchegay commented 2 years ago

Well, the base repository also fails so I pushed the node version from the github actions of sylius/sylius.

I also changed the symfony versions in composer.json

mamazu commented 2 years ago

Sounds good. Though we do still sadly need Symfony 4 support.

xaviermarchegay commented 2 years ago

No problem, I just re-added Sf4.4

mamazu commented 2 years ago

Hm, tests are failing but I think that is because of something else. Can you try to debug them?

xaviermarchegay commented 2 years ago

I fixed a number of errors (exclude some testing combinations, fixed the .env, removed a unsupported node version, etc.)

The remaining error looks like: https://gitlab.com/DMore/chrome-mink-driver/-/issues/119

I am going to try to reproduce the error on my env

mamazu commented 2 years ago

If you can't reproduce them, then we will just check it again manually and then merge it without the pipeline being green.

xaviermarchegay commented 2 years ago

I tried different things but I cannot seem to reproduce it...

mamazu commented 2 years ago

Yeah, behat can be a pain in the butt sometimes. We'll just merge it without it being green then.