search

Brille24 / SyliusCustomOptionsPlugin

A Sylius plugin that adds customer options
MIT License
47 stars 34 forks source link

Update plugin to php8 #137

Closed mamazu closed 1 year ago

seizan8 commented 1 year ago

Symfony recommends not using autoconfigure and autowiring in bundles. I noticed they were used in some configs. Is this deliberate?

https://symfony.com/doc/current/bundles/best_practices.html#services

_If the bundle defines services, they must be prefixed with the bundle alias instead of using fully qualified class names like you do in your project services. For example, AcmeBlogBundle services must be prefixed with acmeblog. The reason is that bundles shouldn't rely on features such as service autowiring or autoconfiguration to not impose an overhead when compiling application services

mamazu commented 1 year ago

Oh that's good to know. I didn't think that it would be a performance hit associated with that if it's done in plugins. But I guess performance is more important than DX in this case.

mamazu commented 1 year ago

Reverted the changes in auto-configuration and just doing the update to php8.