search

Brille24 / SyliusCustomOptionsPlugin

A Sylius plugin that adds customer options
MIT License
47 stars 34 forks source link

add channel context to the OrderItemOptionFactory #147

Closed t-n-y closed 6 months ago

mamazu commented 8 months ago

How can that be that the order doesn't have a channel? And using the channel context will break creating an order from the admin panel.

t-n-y commented 8 months ago

@mamazu @seizan8 I don't know neither. I don't understand how it is possible. i opened an issue with my problem https://github.com/Brille24/SyliusCustomOptionsPlugin/issues/146

seizan8 commented 8 months ago

@t-n-y I don't think this change is a good idea. Maybe there is something wrong somewhere else tho. The OrderItem should always have an order. If that is not the case, we better fix that than add this change.

t-n-y commented 8 months ago

@seizan8 i understand. tell me if you can reproduce this error or if you need more explanations

seizan8 commented 8 months ago

@t-n-y sorry man, I currently have no time to look into this

t-n-y commented 8 months ago

@seizan8 no pb, same for me. will see if i can find some time in the next days

JoppeDC commented 7 months ago

@t-n-y Just for info, I've been able to reproduce this issue by using a Select option on a product