search

Brille24 / SyliusCustomOptionsPlugin

A Sylius plugin that adds customer options
MIT License
47 stars 34 forks source link

DI Extension for Migrations messes up project migrations #148

Closed JoppeDC closed 7 months ago

JoppeDC commented 7 months ago

The following DI extension should IMO not be included in this plugin: https://github.com/Brille24/SyliusCustomOptionsPlugin/blob/master/src/DependencyInjection/Brille24SyliusCustomerOptionsExtension.php

This extension completely messes with the project migrations. Without any additional code and configuration, this will cause project migrations to generate in the vendor dir. Besides that, it will always load the bundle migrations, which shouldn't happen (these migratinos should be generated and run in the project itself). Besides that, the migrations included in the plugin also appear to be broken.

mamazu commented 7 months ago

Yes, this plugin still uses the old structure where the bundle generates the structure. The plugin needs to be updated. If you want to dig into that, I'd happily merge that.

This also ties into the xml to attribute migration. Sadly I have no experience with the migration.

JoppeDC commented 7 months ago

Hi @mamazu , I've updated the doctrine entities to use the newer attributes, and removed the old way of migrations. If you have the time, please have a look at the changes. We can continue the conversation on the PR thread.