search

Brille24 / SyliusCustomOptionsPlugin

A Sylius plugin that adds customer options
MIT License
47 stars 34 forks source link

Fix deprecation #52

Closed antiseptikk closed 4 years ago

antiseptikk commented 4 years ago

Fix #51

mamazu commented 4 years ago

Thank you for your contribution. The reason why the old method still exists is for backwards compatibility. And I have a question about the changes you are suggesting: Is iterable the type on the method in the AbstractType because if not we might get problems when the type hint in Symfony gets official.

antiseptikk commented 4 years ago

Hi @mamazu, good question ! In Symfony i don't know, but i think it's a logical choice. In the Sylius documentation the method is typed as follows https://docs.sylius.com/en/latest/customization/form.html

mamazu commented 4 years ago

In the Symfony documentation it also says iterable. Then I will accept your pull request.