search

Brisanet / ion-react

Ion design system in react
https://main--63da5890a06a8f8f995110dd.chromatic.com/
MIT License
10 stars 1 forks source link

feat: button on loading mode #165

Closed danilo-moreira-brisa closed 6 months ago

danilo-moreira-brisa commented 6 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

This update introduces a new loading prop across the Button component in a React project, enabling the display of a loading spinner. The changes span across component logic, tests, styles, and storybook entries to ensure a comprehensive implementation and visualization of the loading state in buttons.

Changes

Files Changes Summary
src/components/button/button.test.tsx Added tests for loading spinner in various states.
src/components/button/button.tsx Introduced loading prop, updated component logic to handle spinner.
src/components/button/styles.ts Updated styles to include loading state colors and properties.
src/stories/button/button.stories.tsx Added storybook entry to visualize the loading state.

Possibly related issues

Poem

🐇💻✨
In the meadow of code, under the sky so wide,
A new feature hops in, with a spinner at its side.
Click me not, for I'm busy, spinning dots so bright,
A button now resting, in its loading plight.
🔄🔘🐰

Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 8305361308660c52c293ae0b5dde223ea43f3b33 and a3f54b67d902c78c5c7f1e6567cc6a5a8d2dc385.
Files selected for processing (4) * src/components/button/button.test.tsx (1 hunks) * src/components/button/button.tsx (4 hunks) * src/components/button/styles.ts (8 hunks) * src/stories/button/button.stories.tsx (1 hunks)
Files skipped from review due to trivial changes (2) * src/components/button/button.test.tsx * src/stories/button/button.stories.tsx
Additional comments not posted (9)
src/components/button/button.tsx (4)
`20-20`: The addition of the `loading` property to `ButtonProps` is well-implemented and aligns with the PR's objectives to enable a loading state for the button. --- `23-28`: The `ICON_SIZE` constant is well-defined for different button sizes. This ensures consistency in the spinner size across different button sizes. --- Line range hint `38-64`: The conditional rendering of the spinner or icon based on the `loading` state is correctly implemented. Ensure that the `IonSpinner` and `IonIcon` components are tested for their behavior when the `loading` prop changes. --- `57-57`: The `$loading` style prop is correctly passed to the styled `Button` component, allowing for style adjustments based on the loading state.
src/components/button/styles.ts (5)
`13-13`: The addition of the `$loading` property to `ButtonStylesProps` is correctly implemented, allowing for conditional styling based on the loading state. --- `27-27`: The `loading` state has been correctly added to `ColorDefinitions`, enabling specific color definitions for the loading state. --- `94-96`: The loading color definitions for the `primary` variant are well-defined, ensuring visual consistency when the button is in a loading state. --- `119-123`: The loading color definitions for the `secondary` variant are correctly specified, providing clear visual cues for the loading state. --- Line range hint `233-258`: The conditional styling based on the `$loading` property is well-implemented, ensuring that the button's appearance is appropriately adjusted when in a loading state.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.