search

Brisppy / twitch-archiver

A simple, fast, platform-independent tool for downloading Twitch streams, videos, and chat logs.
GNU Affero General Public License v3.0
67 stars 6 forks source link

fix: overwrite of argument values #13

Closed HeliosLHC closed 1 year ago

HeliosLHC commented 1 year ago

Sanitize on a new copy of argument dictionary instead of overwriting values in the original Argument class due to return-by-reference of Python in regards of dicts.

Currently value are independently sanitized in two places:

  1. For debug logging for initial CLI args in init.py
  2. For debug logging for finalize config in Configuration class
HeliosLHC commented 1 year ago

Forgot to clarify that this fixes the broken OAuth authentication to Twitch due to client_id and client_secret being overwritten by the sanitization process as it was overwriting the original values that was to be sent to Twitch.

Brisppy commented 1 year ago

Thanks for catching this and the PR, will merge with the next release.