search

BristolMyersSquibb / blockr

Composable, extensible no-code UI
https://bristolmyerssquibb.github.io/blockr/
GNU General Public License v3.0
32 stars 3 forks source link

Rendered block loading not disappearing #388

Closed JohnCoene closed 2 months ago

JohnCoene commented 2 months ago

This a (probably temp) fix to the loading issue.

On my end the loading icon sometimes does not go away.

@DivadNojnarg it's not a super elegant solution but it's to do with the (AFAIK) new Shiny's renderAsync function, it's impossible to tell when a piece of UI is rendered.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.80%. Comparing base (39aec7b) to head (d2ae237).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #388 +/- ## ======================================= Coverage 84.80% 84.80% ======================================= Files 21 21 Lines 2158 2159 +1 ======================================= + Hits 1830 1831 +1 Misses 328 328 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JohnCoene commented 2 months ago

Sorry about the nasty console.log it's removed