BristolMyersSquibb / blockr

Composable, extensible no-code UI
https://bristolmyerssquibb.github.io/blockr/
GNU General Public License v3.0
34 stars 3 forks source link

Broken join block #441

Open JohnCoene opened 3 hours ago

JohnCoene commented 3 hours ago

Join block is broken as far as I can tell.

@DivadNojnarg is it needed for workshop?

library(blockr)
library(shiny)

dat1_stack <- new_stack(
  new_dataset_block(selected = "iris"),
  name = "dat1",
  title = "First dataset"
)

dat2_stack <- new_stack(
  new_dataset_block(selected = "iris"),
  name = "dat2",
  title = "Second dataset"
)

merged_stack <- new_stack(
  new_result_block("dat1"),
  new_join_block(y = "dat2", type = "left", by = "Species")
)

ui <- fluidPage(
  theme = bslib::bs_theme(5L),
  div(
    class = "row",
    div(
      class = "col-md-6",
      generate_ui(dat1_stack)
    ),
    div(
      class = "col-md-6",
      generate_ui(dat2_stack)
    )
  ),
  generate_ui(merged_stack)
)

server <- function(input, output, session) {
  generate_server(dat1_stack)
  generate_server(dat2_stack)
  generate_server(merged_stack)
}

shinyApp(ui, server)
DivadNojnarg commented 2 hours ago

Yes that's a consequence of the result block issue in #439 and #432. We don't need it for the workshop but that's still high priority.

JohnCoene commented 2 hours ago

@DivadNojnarg which version should I revert to so that it works? I need to deploy a demo app with joins.

DivadNojnarg commented 2 hours ago

I did not released the very latest main so you can use this one: https://github.com/BristolMyersSquibb/blockr/releases/tag/v0.0.2.9023.

karmatarap commented 2 hours ago

@DivadNojnarg. Please can we fix this as a priority as it is one of the key selling points for the demos (PhuUSE EU + internal)