BristolTopGroup / NTupleProduction

Software for particle physics to create nTuples from AOD files
Other
2 stars 8 forks source link

Egm updates and jer #281

Closed DouglasBurns closed 7 years ago

DouglasBurns commented 7 years ago

Add JER and SF to ntuples

Electron Regression (From either GT, online database or local files) Will use GT but currently incompatible with EGMSmeaer. Using Online database presently.

EGM Smearer. Smear MC and Scale data. produces new collection of CalibratedPatElectrons which is passed to electronUserData. The electronID has had to be tweaked and everything is consolidated in a new electron_setup script.

EGM energy seed corrections. Currently have to be applied on top of EGMSmearer, in the future it will be a part of the smearer. ElectronID is calculated without this taken into account, the effect will be negligable though.

mention-bot commented 7 years ago

@DouglasBurns, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kreczko, @EmyrClement and @senkin to be potential reviewers.

EmyrClement commented 7 years ago

Just checking:

-In data, electrons are scale

-In MC, electrons are scaled and then smeared

Is this what's been implemented?

On 24/01/2017 15:06, DouglasBurns wrote:

@DouglasBurns commented on this pull request.


In python/run/miniAODToNTuple_cfg.py https://github.com/BristolTopGroup/NTupleProduction/pull/281:

@@ -150,6 +152,7 @@ else: process.makingNTuples = cms.Path(

process.metFilters *

  • process.smearedElectrons *

So for real data the electrons are scaled instead of smeared - Both the scaling and smearing are performed by the same module which takes in an isMC bool.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BristolTopGroup/NTupleProduction/pull/281, or mute the thread https://github.com/notifications/unsubscribe-auth/AEO6q0ZiaCnN5DFMSe7BKHz5qIDCaw1Pks5rVhNegaJpZM4LsQto.

DouglasBurns commented 7 years ago

From my understanding... MC is Smeared, Data is scaled (twice). Both on top of any Regression scaling.

EmyrClement commented 7 years ago

Why is data scaled twice?

I went back to the TOP PAG egamma slides : https://indico.cern.ch/event/600194/contributions/2423590/attachments/1397208/2130488/Egamma_TopPAG_17.01.pdf

Slide 4 says what energy corrections needs to be applied (all after regression correction):

So MC is scaled and then smeared. Data is scaled only.

On 24/01/2017 15:31, DouglasBurns wrote:

From my understanding... MC is Smeared, Data is scaled (twice). Both on top of any Regression scaling.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BristolTopGroup/NTupleProduction/pull/281#issuecomment-274837240, or mute the thread https://github.com/notifications/unsubscribe-auth/AEO6q7Di8JcERWRZQotHtJ5Fl8RQybd4ks5rVhlEgaJpZM4LsQto.

DouglasBurns commented 7 years ago

You are correct. I also went back to slides and found out. data has an additional scaling depending on whether it is in the barrel: https://twiki.cern.ch/twiki/bin/viewauth/CMS/EGMSmearer#ECAL_scale_and_resolution_correc This wil be incorporated into EGMSmearer but is not presently

DouglasBurns commented 7 years ago

Updated PR moreMor17

kreczko commented 7 years ago

so superseded by #283