search

BriteSnow / snow

A Lightweight, Google Guice, Simple, and Powerful Web Application Framework that makes building modern Web Application a breeze! Fully open source, Apache V2 licensed.
http://britesnow.com/snow
29 stars 10 forks source link

Add TestNG support #38

Closed imranzahid01 closed 10 years ago

imranzahid01 commented 10 years ago

A lot of people JUnit for testing, but there are many who use TestNG (http://testng.org/doc/index.html) as well. I just copied over the SnowTestSupport file to SnowTestSupportNG which uses TestNG specific annotations.

I am using this in one of my public projects, and for example you can have a look at it (http://www.imranzahid.org/imranzahid/events/blob/master/src/test/java/com/imranzahid/events/test/dao/UserDaoTestNG.java)

jeremychone commented 10 years ago

@imranzahid01 So, I changed a little bit the SnowTestSupport class strategy. I have decided to remove any unit framework dependency from this class and allow unit framework testing support via a very simple inheritance pattern. In short, application developer can simply extend this SnowTestSupport class with their own ApplicationBaseTestSupport and implement their base behaviors for their unit framework of choice.

I think it is the cleanest way to do, and in fact, even if the previous pattern, developer still have to extends this class anyway for implementing the @BeforeClass anyway.

Also, I have moved to IntelliJ ;), so I have added this to the gitignore.

I will add your good modification about the logger manually (I think there are spot on).

Thanks a lot for the feedback. Feel free to look at the commit history, I tried to keep it very clean and informative (+ for addition, ! for change of API, * for important, . for minor).

jeremychone commented 10 years ago

@imranzahid01 Btw, thanks a lot for this good feedback, and I hope you still have fun with Snow. We are using it a lot at BriteSnow (for all our Java projects) and we are thrilled when people use it as well.

Best,