search

British-Oceanographic-Data-Centre / COAsT

A Coastal Ocean Assessment Tool built as an extendable python framework for nemo models
https://british-oceanographic-data-centre.github.io/COAsT/
MIT License
24 stars 11 forks source link

GitAction to autogenerate unit_test contents #421

Open jpolton opened 2 years ago

jpolton commented 2 years ago

Add this https://github.com/British-Oceanographic-Data-Centre/COAsT/blob/develop/unit_testing/generate_unit_test_contents.py to GitActions

lukegorman commented 2 years ago

working on this

thogar-computer commented 2 years ago

oo I was as well haha, I can stop (I've only just started)

https://github.com/British-Oceanographic-Data-Centre/COAsT/blob/0db2cb7571a942ddc30783894f0b091bfde37a4b/unit_testing/generate_unit_test_contents.py#L43

I think this line might need looking at as the file is open and never closed...

thogar-computer commented 2 years ago

@jpolton @katavouta

as this python file doesn't run the tests I am unsure what the logger is for?

also adding a comment to the line https://github.com/British-Oceanographic-Data-Centre/COAsT/blob/0db2cb7571a942ddc30783894f0b091bfde37a4b/unit_testing/generate_unit_test_contents.py#L88

as to what that value means would be really useful

jpolton commented 2 years ago

@jpolton @katavouta

as this python file doesn't run the tests I am unsure what the logger is for?

also adding a comment to the line

https://github.com/British-Oceanographic-Data-Centre/COAsT/blob/0db2cb7571a942ddc30783894f0b091bfde37a4b/unit_testing/generate_unit_test_contents.py#L88

as to what that value means would be really useful

@thogar-computer Comment added to branch to be merged. (It is an alphabetical counter: char(method_count) = a, b, c, ...)