Open jpolton opened 2 years ago
The team will aim to get work into master in an incremental fashion when we are nearing the end of the sprint - last 3 day - we will all work to get in-progress tickets finished and closed to allow for an end-of-print push to zenodo
Previously I've added summaries to the Zendo release: https://zenodo.org/record/6424329#.YrQgvC8w36U
Work flow on pushing to master: https://british-oceanographic-data-centre.github.io/COAsT/docs/contributing_package/push_to_master/
Add @lukegorman to the CITATIONS.cff file
@lukegorman has said he will do a clean install and run thought to check develop branch is working as expected.
We have also asked if the MSM group (@jpolton @anwiseNOCL) could do the same to make sure that their are happy from a users point of view.
Testing on Mac:
run unit_testing/unit_test.py
3 issues in test_tidegauge_methods.py
file:
...
observed variable exist
ok
test_gridded_load_bgc_data (test_bgc_gridded_initialisation.test_bgc_gridded_initialisation) ... OK reshape successful
alkalinity
variable not in observations
/Users/jeff/GitHub/COAsT/coast/_utils/logging_util.py:79: UserWarning: /Users/jeff/GitHub/COAsT/coast/data/gridded.py._setup_grid_obj.80: No NEMO domain specified, only limited functionality will be available
return warnings.warn(add_info(msg), *args, **kwargs)
ok
test_gridded_load_bgc_data_and_domain (test_bgc_gridded_initialisation.test_bgc_gridded_initialisation) ... ok
test_gridded_load_bgc_dimensions_correctly_renamed (test_bgc_gridded_initialisation.test_bgc_gridded_initialisation) ... ok
test_gridded_load_bgc_domain_only (test_bgc_gridded_initialisation.test_bgc_gridded_initialisation) ... ok
test_gridded_load_bgc_variables_correctly_renamed (test_bgc_gridded_initialisation.test_bgc_gridded_initialisation) ... ok
test_statsmodel_seasonal_decompose (test_process_data.test_process_data_methods) ... ok
======================================================================
FAIL: test_harmonic_analysis_utide (test_tidegauge_methods.test_tidegauge_analysis) [Do harmonic analysis]
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/jeff/GitHub/COAsT/unit_testing/test_tidegauge_methods.py", line 63, in test_harmonic_analysis_utide
self.assertTrue("M2" in ha[0].name, "check1")
AssertionError: False is not true : check1
======================================================================
FAIL: test_harmonic_analysis_utide (test_tidegauge_methods.test_tidegauge_analysis) [Reconstruct time series]
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/jeff/GitHub/COAsT/unit_testing/test_tidegauge_methods.py", line 76, in test_harmonic_analysis_utide
self.assertTrue(np.isclose(reconstructed.dataset.test[0, 0].values, 1.92296937), "check3")
AssertionError: False is not true : check3
======================================================================
FAIL: test_harmonic_analysis_utide (test_tidegauge_methods.test_tidegauge_analysis) [Calculate non-tidal residuals]
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/jeff/GitHub/COAsT/unit_testing/test_tidegauge_methods.py", line 82, in test_harmonic_analysis_utide
self.assertTrue(np.isclose(ntr.dataset.ntr[0, 0], 0.00129846), "check1")
AssertionError: False is not true : check1
----------------------------------------------------------------------
Ran 67 tests in 250.266s
FAILED (failures=3)
@lukegorman do you have this too?
merge from develop to master complete. need to make a release.
AC: At end of sprint issue new conda/pip/zenodo release with documentation site updated with new changes