British-Oceanographic-Data-Centre / COAsT

A Coastal Ocean Assessment Tool built as an extendable python framework for nemo models
https://british-oceanographic-data-centre.github.io/COAsT/
MIT License
24 stars 11 forks source link

606 circulation and fluxes in global model data jp #616

Closed jpolton closed 1 year ago

jpolton commented 1 year ago

@jasontempestholt These are the fixes I did during the review of your Pull Request. If you are happy with these, we (you) can update your branch with them. Then I will merge your branch into Develop.

Use "Files Changed" tab (5cm above) to see the differences:

  1. updated to the latest version of Develop
  2. changed a few names to make them more COAsT
  3. abstracted and simplified your subsetting method in Gridded()
  4. refactored the velocity_on_t_points so that the differences across indices are not a function of dimension ordering (I'm also hoping it might scale better with xarray backend magic)