search

British-Oceanographic-Data-Centre / COAsT

A Coastal Ocean Assessment Tool built as an extendable python framework for nemo models
https://british-oceanographic-data-centre.github.io/COAsT/
MIT License
23 stars 11 forks source link

remove deprec warning #649

Closed soutobias closed 8 months ago

soutobias commented 8 months ago

After updating the Python version, there were still some deprecation warnings present in the code. I successfully addressed and resolved all of the warnings associated with the COAsT code. However, there remain certain warnings related to the xarray and utide libraries, which cannot be eliminated since they pertain to dependencies. I also chose to retain one warning labeled as "Pending" because I believe it may only become relevant in the distant future.

soutobias commented 8 months ago

Resolves https://github.com/British-Oceanographic-Data-Centre/COAsT/issues/629, resolves https://github.com/British-Oceanographic-Data-Centre/COAsT/issues/558

soutobias commented 8 months ago

@jpolton , I fixed the cmap stuff and now it works. I also updated all github actions related to notebooks. An error occurred in the python version, as it was instantiated twice: in the workflow and in the environment.yml. So, I removed the workflow version for these tests.

jpolton commented 8 months ago

Great work. I'll merge it.