British-Oceanographic-Data-Centre / COAsT

A Coastal Ocean Assessment Tool built as an extendable python framework for nemo models
https://british-oceanographic-data-centre.github.io/COAsT/
MIT License
23 stars 11 forks source link

0653/merge plot polar contour #654

Closed b-barton closed 7 months ago

b-barton commented 7 months ago

Pull request checklist

Please check if your PR fulfills the following requirements:

Pull request type

Please check the type of change your PR introduces: - [x ] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior?

The plot_util.plot_polar_contour() function wasn't working as expected. This could be tested using example_scripts\configuration_gallery\gc31_arctic_example_plot.py and looking at the output figure. The contours do not wrap correctly.

Issue URL: #653

What is the new behavior?

The cartopy solution has been put in. A transform=ccrs.epsg(3413) is needed in the .contour() so I've taken out the use of pyproj. This now plots contours correctly with example_scripts\configuration_gallery\gc31_arctic_example_plot.py

-

Checklist

Does this introduce a breaking change?

Other information

b-barton commented 7 months ago

I've no idea how these black formatting things work. It failed. Then I changed stuff, it still failed. I changed stuff back and it works?????