Closed volcan01010 closed 2 years ago
This looks good locally. I pushed a very minor flake8 fix to satisfy the developer tests. One of the Python builds is failing. Is this a pull-stopper?
I got this working now. There was something wrong with the pip install
process in the Travis build for Python 3.7. I upgraded some of the install dependencies and now it works. Will merge. Thanks for review.
This pull request makes a number of small improvements to close multiple issues.
To test
Most of the changes are covered by tests. To see them manually:
Not covered by tests
python etlhelper/setup_oracle_client.py
. There should be a helpful error message. Closes #101Covered by tests
generate_insert_sql
. Closes #119load
command (e.g. from recipe example in README) and note that the number of rows processed and failed is returned. Closes #114load
command with empty array and note lack of error. Closes #120