Closed ximenesuk closed 1 year ago
I've tested this request on various scripts and all passed fine. Ready to commit
I've just been going through other files to change for #158, and it seems there are still some mentions of the old setup_oracle_client
in CONTRIBUTING.md and potentially bin/run_tests_for_developer.sh too.
Also, should this merge request be for for_v1
rather than main
?
OK, well spotted. I'll change the target branch and update the docs.
This all works for me and I'm happy to merge into for_v1
.
Note that https://github.com/BritishGeologicalSurvey/etlhelper/issues/110 discusses handling LOBs in a different way. We should experiment with this now and decide what the default setting should be.
This pull request replaces
cx_Oracle
libraries withoracledb
and bumps the minimum Python version to 3.9The brute force approach of globally replacing
cx_Oracle
withoracledb
and addingcffi
as a dependency resulted in all the tests passing. In addition thesetup.py
file has been updated to the new libraries. Therequirements.txt
file has also been updated. As an asideall
has been added to setup uptions.To test:
etlhelper
shouldpip install
from this branch (withall
option as additional test)pip install git+https://github.com/BritishGeologicalSurvey/etlhelper@oracledb#egg=etlhelper[all]
pip install git+https://github.com/BritishGeologicalSurvey/etlhelper@oracledb#egg=etlhelper[oracle]
Closes #140 and #160