Set default row factory to `as_dict`

BritishGeologicalSurvey / etlhelper

ETL Helper is a Python ETL library to simplify data transfer into and out of databases.

https://britishgeologicalsurvey.github.io/etlhelper/

GNU Lesser General Public License v3.0

104 stars 25 forks source link

Set default row factory to `as_dict` #153

Closed rbroth closed 1 year ago

rbroth commented 1 year ago

(because dictionaries are more common and easier to use, with mutability built-in, and faster to build than named tuples). Related to #132.

Acceptance Criteria

[x] The default row factory for all functions is set to dict_row_factory
[x] Tests are updated to account for this change
[x] Documentation is updated

rbroth commented 1 year ago

This will be a breaking change and the major version should be incremented when this merged into main

leorudczenko commented 1 year ago

I've made the change to the default row factory for all functions in etlhelper/etl.py. I have also made changes to tests which were broken by the change. Due to connection problems on my end, I haven't been able to run the mssql tests. However, I can confirm that all of the other tests are now passing with the change.

volcan01010 commented 1 year ago

I'm updating this now. There is a problem with the msql tests, in that the fast_executemany command that it uses behind the scenes wants a tuple as an input.

volcan01010 commented 1 year ago

Closing as it has now been merged into for_v1.