As an etlhelper developer, I would like to deprecate the get_rows function as it is a duplicate of fetchall so that there is less code / documentation to maintain.
Description
In early implementations of ETL Helper, the get_rows function was written to return all the rows. In time, we added more functions and aligned their names with the PEP 249 DB-API specs. fetchall performs exactly the same task as get_rows.
We now want to remove get_rows to minimise the code base. If you want to get all the rows, "There should be one-- and preferably only one --obvious way to do it.". fetchall is better as it is familiar from the PEP 249 specs.
This will require wide updates of the documentation, as well as updates to tests.
Acceptance criteria
[x] get_rows is replaced by fetchall throughout code and documentation.
volcan01010
commented
1 year ago
Summary
As an etlhelper developer, I would like to deprecate the
get_rowsfunction as it is a duplicate offetchallso that there is less code / documentation to maintain.Description
In early implementations of ETL Helper, the
get_rowsfunction was written to return all the rows. In time, we added more functions and aligned their names with the PEP 249 DB-API specs.fetchallperforms exactly the same task asget_rows.We now want to remove
get_rowsto minimise the code base. If you want to get all the rows, "There should be one-- and preferably only one --obvious way to do it.".fetchallis better as it is familiar from the PEP 249 specs.This will require wide updates of the documentation, as well as updates to tests.
Acceptance criteria
get_rowsis replaced byfetchallthroughout code and documentation.