Further testing

[dvalters]

Summary

See coverage html.

• [ ] Test on the zip location download (mock out download ziplfile, if zipfile location starts with http)
• [x] Test on the args parse (can they be mocked?)
• [ ] Test returns when oracle client is configured and not a reinstall (check log messages?)
• [x] Check check install status when the install dir is empty.

[volcan01010]

Something like this should test the argparse:

# Arrange
mock_setup_oracle_client_function = Mock()
monkeypatch.setattr(soc, 'setup_oracle_client', mock_setup_oracle_client_function)
monkeypatch.setattr(sys, 'argv', ['setup_oracle_client', '-z', 'http://some.url', '--reinstall', '-v'])

# Act (call main from setup_oracle_client module)
main()

# Assert
mock_setup_oracle_client.assert_called_with(...)

Tests could cover with and without --zip-location and --reinstall.

[volcan01010]

This work was completed in #55.