Ensure setup_oracle_client runs on sh and zsh

BritishGeologicalSurvey / etlhelper

ETL Helper is a Python ETL library to simplify data transfer into and out of databases.

https://britishgeologicalsurvey.github.io/etlhelper/

GNU Lesser General Public License v3.0

105 stars 25 forks source link

Ensure setup_oracle_client runs on sh and zsh #82

Closed volcan01010 closed 4 years ago

volcan01010 commented 4 years ago

Description

This change in syntax in setup_oracle_client ensures that the ld_libary_prepend.sh script runs on sh shell. A Dockerfile is added to confirm this, and that it works with zsh, too. I looked into csh and tcsh, too, but they have completely different syntax. We can consider supporting them if someone requests it, but we don't need it ourselves.

The Dockerfile is not used as part of routine testing.

Closes #80

To test

[ ] Follow the instructions in test/Dockerfile.test_shells to check commands work

volcan01010 commented 4 years ago

I'm in two minds about whether or not to include the Dockerfile. If we never use it again it will just be clutter. Thoughts appreciated.

volcan01010 commented 4 years ago

I've decided to remove the Dockerfile. If we need it back again, the code is in this commit: https://github.com/BritishGeologicalSurvey/etlhelper/pull/82/commits/ca4a6efaca16f7fe7d5f4fbcf71ab24b4a066364

volcan01010 commented 4 years ago

I'll merge this; the full suite of tests pass so the build does work.

metazool commented 4 years ago

Thank you. I started looking at this but got caught up in other work waiting for the build, and never made the time to come back. It's good to see the fix It's nice to have an example Dockerfile in the project, even though it wasn't being used in CI it was still a useful contribution