Closed volcan01010 closed 4 years ago
I'm in two minds about whether or not to include the Dockerfile. If we never use it again it will just be clutter. Thoughts appreciated.
I've decided to remove the Dockerfile. If we need it back again, the code is in this commit: https://github.com/BritishGeologicalSurvey/etlhelper/pull/82/commits/ca4a6efaca16f7fe7d5f4fbcf71ab24b4a066364
I'll merge this; the full suite of tests pass so the build does work.
Thank you. I started looking at this but got caught up in other work waiting for the build, and never made the time to come back. It's good to see the fix It's nice to have an example Dockerfile in the project, even though it wasn't being used in CI it was still a useful contribution
Description
This change in syntax in setup_oracle_client ensures that the
ld_libary_prepend.sh
script runs onsh
shell. A Dockerfile is added to confirm this, and that it works withzsh
, too. I looked intocsh
andtcsh
, too, but they have completely different syntax. We can consider supporting them if someone requests it, but we don't need it ourselves.The Dockerfile is not used as part of routine testing.
Closes #80
To test
test/Dockerfile.test_shells
to check commands work