Export of boreholes by IDs and polygon

[ximenesuk]

This PR closes #99 providing two endpoints:

• /ags_export/?bgs_loca_id= that will export a zip containing one or more multiple boreholes, with maximum of 10, and associated metadata by id
• /ags_export_by_polygon/?polygon= that will export a zip containing one or more boreholes, with maximum of 10, and associated metadata of those boreholes found in the polygon described by Well Known Text.

All the tests should all pass locally. A number of integration tests are expected to expected to fail using github actions while the upstream endpoint is not externally available.

Using an internally deployed server check that ags_export:

• [x] returns a zip for a known bgs_loca_id
• [x] returns a zip for a list known IDs: bgs_loca_id1;bgs_loca_id3;bgs_loca_id3
• [x] returns errors for unknown IDs or a string of more than 10 IDs

And check that ags_export_by_polygon:

• [x] returns a json response containing a count of the number of boreholes in a polygon when &count_only=True is added
• [x] returns a zip for a WKT polygon containing 10 or fewer boreholes
• [x] returns errors for empty polygons, polygons with more than 10 boreholes and badly formed WKT

See the tests for some example cases.

[KoalaGeo]

@volcan01010 if your happy I'll make the front end changes to use these endpoints and release

[KoalaGeo]

@volcan01010 & @ximenesuk I've added the links to the ags_export endpoint in the leaflet map popups.

I'm holding off adding the polygon select functionality for now, but having the endpoint available is great!

Once reviewed I'll get it released and deployed.

[ximenesuk]

@volcan01010 & @ximenesuk I've added the links to the ags_export endpoint in the leaflet map popups.

I'm holding off adding the polygon select functionality for now, but having the endpoint available is great!

Once reviewed I'll get it released and deployed.

John is off this week but hopefully he can review it fairly quickly once he's back. As an aside the API allows the download of multiple AGS files in one call, though this was more for internal reuse reasons and need not be exposed via the seb service.

[volcan01010]

I wonder if we should use a more generic 400 Bad Request error for when you request a Polygon with more than 10 boreholes. To me, the 404 suggests that we have gone to a URL that doesn't exist, rather than given some bad data.

Here is what the HTTP cats say:

• https://http.cat/status/400
• https://http.cat/status/404

The returned JSON says "Bad request" in a few locations:

{
  "msg": "Not found",
  "type": "bad request",
  "self": "http://localhost:8000/ags_export_by_polygon/?polygon=POLYGON%28%28-4.5%2056%2C-4%2056%2C-4%2055.5%2C-4.5%2055.5%2C-4.5%2056%29%29&count_only=false",
  "errors": [
    {
      "error": "Bad request",
      "propName": null,
      "desc": "More than 10 boreholes (2211) found in the given polygon. Please try with a smaller polygon"
    }
  ]
}

[ximenesuk]

I wonder if we should use a more generic 400 Bad Request error for when you request a Polygon with more than 10 boreholes. To me, the 404 suggests that we have gone to a URL that doesn't exist, rather than given some bad data.

I'm more than happy to go to 400. You are right that 404 doesn't really express the error here and 422 didn't seem right as the polygon is valid.