search

BritishGeologicalSurvey / pyagsapi

pyagsapi - An AGS Utilities API with AGS v4.x Schema Validation & Converter for .ags<-->.xslx files
https://britishgeologicalsurvey.github.io/pyagsapi/
GNU Lesser General Public License v3.0
12 stars 2 forks source link

JSON has an incorrect error count, includes warnings & fyi #151

Open Rogerchandler opened 1 month ago

Rogerchandler commented 1 month ago

The JSON return string returns a message along the lines of "100 errors found" - this number includes all the FYI and Warnings. So a file with no errors still shows it has errors.

KoalaGeo commented 3 weeks ago

@Rogerchandler thanks for highlighting. We'll ammend the text to "100 errors/warnings/fyi found"

Rogerchandler commented 3 weeks ago

I think the main concern is that providers want to show that there are officially no errors. "100 errors/warnings/fyi found" does not give them that clear information. 0 errors 81 FYIs and 9 warnings would be perfect :-)

KoalaGeo commented 3 weeks ago

Ah yes see we need to be using https://gitlab.com/ags-data-format-wg/ags-python-library/-/blob/main/python_ags4/AGS4.py?ref_type=heads#L953-L954

&

https://gitlab.com/ags-data-format-wg/ags-python-library/-/blob/main/python_ags4/AGS4.py?ref_type=heads#L1015-1042