BritishGeologicalSurvey / pyagsapi

pyagsapi - An AGS Utilities API with AGS v4.x Schema Validation & Converter for .ags<-->.xslx files
https://britishgeologicalsurvey.github.io/pyagsapi/
GNU Lesser General Public License v3.0
12 stars 2 forks source link

Fixes for empty point geometries and more #70

Closed volcan01010 closed 1 year ago

volcan01010 commented 1 year ago

Summary

This merge request fixes crashes where items had empty point geometries. There are a few minor improvements as well.

Closes #57 and the requirement for .AGS files.

To test

Run the application:

Run the tests:

ximenesuk commented 1 year ago

There is still one tiny issue:

INFO | 2023-02-23 08:39:06,975 | app.checkers | Checking against BGS data validation: LOCA within Great Britain
/media/colin/Data/repos/AGS/AGS-Validator-external/.venv/lib/python3.11/site-packages/shapely/predicates.py:798: RuntimeWarning: invalid value encountered in intersects
  return lib.intersects(a, b, **kwargs)
INFO | 2023-02-23 08:39:23,194 | app.checkers | Checking against BGS data validation: LOCA_LOCX is not duplicate of other column

So there must still be a duff point in the East West Railway file somewhere. However, the tests pass and so I am going to merge this now and create an issue for this to be investigated. The checking of the East West Railway file finishes on my system quickly enough but I still get a crash due to the size on the JSON file, but that's not related to our code.