search

BritishGeologicalSurvey / pyagsapi

pyagsapi - An AGS Utilities API with AGS v4.x Schema Validation & Converter for .ags<-->.xslx files
https://britishgeologicalsurvey.github.io/pyagsapi/
GNU Lesser General Public License v3.0
12 stars 2 forks source link

Check for child consistency for all child groups #73

Closed ximenesuk closed 1 year ago

ximenesuk commented 1 year ago

This PR adds the logic to check for child consistency using the more complex composite IDs. Parent relationships still need to check using the default SAMP IDs. The IDs fro the child groups that are not one-to-one with SAMP are in the new file. There needs to be more tests for each of the groups using the various ID combinations.

I'm opening this as a draft PR until it is checked potentially refactored.

volcan01010 commented 1 year ago

We went over this on @ximenesuk machine and the tests all pass on mine.

KoalaGeo commented 1 year ago

Closes https://github.com/BritishGeologicalSurvey/pyagsapi/issues/54