search

BritishGeologicalSurvey / stratigraph

Network stratigraphy through text mining
GNU Lesser General Public License v3.0
4 stars 0 forks source link

Filter graph by stratigraphic unit rank #16

Open rachelheaven opened 3 years ago

rachelheaven commented 3 years ago

Graph will probably only draw nicely for units that are of rank 'formation'. We could query the store to only get units of rank formation, but lots of the detail would then be lost. Suggest to include the rank in the data and the front end visualisation can then filter the non-formations out on request.

rachelheaven commented 3 years ago

Dependant on rank being added to the lexicon linked data

metazool commented 3 years ago

Thinking about this, and looking at the sample Jurassic graph in more detail, I think it will be simpler if we keep the filtering on the backend - by default return a graph which only shows Formations, or optionally return one that shows everything. It will be much more of a job to filter the Graphviz output on the frontend than it will to hand it a cleaner dotfile. What do you reckon @scientific-creative

rachelheaven commented 3 years ago

Discussion at stand up was that graph should be drawn for one rank type at a time, either Formation or Member (doesn't make much sense for other rank types)

metazool commented 3 years ago

At the moment the API has three options

This was done quickly in response to feedback on Teams with a note in the code that we'll want to revisit