Closed mobiuscreek closed 3 years ago
I appreciate it. I was looking to add some integration tests for the linking as well, so we can try to quantify the effects/improvements of extending the list of stopwords as suggested in #12
Some of the existing tests are not 'true' unit tests in that they depend on corenlp running in the pipeline as a service, or locally ( as per https://github.com/BritishGeologicalSurvey/stratigraph/blob/main/.github/workflows/test.yml#L11 )
Yes, my bad for not mentioning. An instance of corenlp should be running. The following tests are not 'true' unit tests and will throw a ConnectionError
if it's not running:
tests/test_graph.py - test_bounds_links
should we mock the response at this stage?
It's not a problem that you introduced! I think it's not a problem as it stands, semantics about what are tests or not. I noticed you'd introduced a mock, then saw it was just to catch exceptions right.
Adds better test coverage for the
corenlp
andgraph
modules.Acceptance criteria
[ ] Tests properly test the functionality
[ ] All tests pass