Add tests for corenlp and graph modules

BritishGeologicalSurvey / stratigraph

Network stratigraphy through text mining

GNU Lesser General Public License v3.0

4 stars 0 forks source link

Add tests for corenlp and graph modules #31

Closed mobiuscreek closed 3 years ago

mobiuscreek commented 3 years ago

Adds better test coverage for the corenlp and graph modules.

Acceptance criteria

[ ] Tests properly test the functionality
[ ] All tests pass

metazool commented 3 years ago

I appreciate it. I was looking to add some integration tests for the linking as well, so we can try to quantify the effects/improvements of extending the list of stopwords as suggested in #12

Some of the existing tests are not 'true' unit tests in that they depend on corenlp running in the pipeline as a service, or locally ( as per https://github.com/BritishGeologicalSurvey/stratigraph/blob/main/.github/workflows/test.yml#L11 )

mobiuscreek commented 3 years ago

Yes, my bad for not mentioning. An instance of corenlp should be running. The following tests are not 'true' unit tests and will throw a ConnectionError if it's not running:

tests/test_corenlp.py - test_tokens_works
tests/test_corenlp.py - test_entities
tests/test_corenlp.py - test_fullstop_bugfix
tests/test_graph.py - test_link_entities
tests/test_graph.py - test_bounds_links

should we mock the response at this stage?

metazool commented 3 years ago

It's not a problem that you introduced! I think it's not a problem as it stands, semantics about what are tests or not. I noticed you'd introduced a mock, then saw it was just to catch exceptions right.