Kraken Submission - Githubissues

BrittanyAdair commented 2 years ago

@thatkidmadrid

Hey Chris, I'm submitting the Kraken assignment.

thatkidmadrid commented 2 years ago

I notice you're missing the icons, you're supposed to include them in your images folder and push them to your repo

thatkidmadrid commented 2 years ago

you're missing your descriptions
watch out for how you're using roman numerals in your aria-labels. If you tried to use VoiceOver on your website, you would know why this is an issue.
There are some concerns with the structure of the website which is causing the styling to not work properly.
You're still referencing the old icons in your footer nav.

Please check your website with VoiceOver before submitting, and also keep this submission issue open until I add the grade to LTW. As it is now, I cannot add the grade until you address the notes above

thatkidmadrid commented 2 years ago

Did you mean to close this issue? Please keep this submission issue open until I add the grade to LTW otherwise I may forget to take a look to add the grade. I removed what markbot added to LTW because there are still things missing

BrittanyAdair commented 2 years ago

I think I fix everything that you addressed above

thatkidmadrid commented 2 years ago

Great! I notice the structure is still a bit different from what I expect but let's focus on accessibility and pay attention to the discussion in class later. You are still missing a very important description. The image of a kraken and a ship in the middle of the text has an empty alt attribute. This is very bad for a listener as the screenreader will completely skip it. If you tested the page with VoiceOver it would have been easy to catch this.

[ ] you're missing your descriptions
[x] watch out for how you're using roman numerals in your aria-labels. If you tried to use VoiceOver on your website, you would know why this is an issue.
[x] There are some concerns with the structure of the website which is causing the styling to not work properly.
[x] You're still referencing the old icons in your footer nav.

Ignoring the structure stuff I'll feel comfortable giving you the grade after you finish that last description, but please demonstrate in your future projects that you understand how to use articles well (w3 docs on articles)

BrittanyAdair commented 2 years ago

I just did the last the description on the kraken image

thatkidmadrid commented 2 years ago

Great, that description makes sense to me

Adding the grade on LTW

BrittanyAdair / kraken-good-accessibility

Kraken Submission #1