Open gdevenyi opened 3 years ago
It looks like perhaps the existing affine from bruker is actually correct and the additional corrections added were due to confusion regarding the exact orientation of previous phantom test data?
Confirmed with PV5 as well, that just skipping the correction orientation by adding pass here: https://github.com/BrkRaw/bruker/blob/master/brkraw/lib/orient.py#L24
Results in correct orientations for the Supine/Prone positions.
I will hold off on making any changes yet, as I want to collect all orientations and "subject types" in both PV5 and PV6 in a single session with the phantom universally in the "Head First Prone" position. I think perhaps we may be able to do away with most of this code.
@gdevenyi Sorry for the delay regarding the update of this software. I tried to make the final orientation to be oriented on subject whether the animal positioned supine or prone. So if the resulted orientation is always the same. I think it is correct.
Please let me know if I mis-catch your point. Thanks!
Sorry for the delay, please see email to your github listed email for a orientation dataset to sort this out.
I have been collecting validation datasets for conversion and run into a conversion bug, which was handled properly in 0.3.4, and is wrong in HEAD.
I have a phantom brain in the scanner, physically in the orientation "Head First Prone". I have collected two scans, with PV6 configured as Quadruped, and one scan "Head First Prone" and another "Head First Supine".
brkraw info
properly reports the difference in the data:However, after conversion, both the datasets are in the same orientation:
Left: correct orientation Middle: incorrect orientation, should be rotated
The last commit to touch this code was: https://github.com/BrkRaw/bruker/commit/eaa6db06fd6114922670840b35c0dff041cf4e61
In 0.3.4, it looks like subj_position is ignored for PV6 and applied to PV5, where as in master, it is applied unconditionally.