Bro-Omg56977 / saturated_truedev

somewhat broken version
Creative Commons Zero v1.0 Universal
1 stars 1 forks source link

Spooky events are happening outside of the void. #3

Open KenanTheFab opened 4 days ago

KenanTheFab commented 4 days ago

Cost me a lot of time because my house exploded and got covered in fire. Saved it with /tick freeze and taking out all the fire before unfreezing it.

I have paper randomly appear in my inventory (I am 99% sure it is a jojo reference, referencing the 14 phrases), wither skeletons float in the sky or are suddenly in the overworld, "mannequins" (renamed blank armor stands) appear behind me, etc.

I like this mod for it being vanilla friendly while also spicing things up without being too op (shoutouts to "vanilla friendly" structure mods that give you enough gear that you might aswell go kill the dragon in the next 5 minutes) but the random events are annoying. Paper clutters the inventory, the explosion and flame took out my build, etc and I feel like this patch wasn't tested properly when it adds such drastic events.

As an aside: holy shit please tone down the spawnrates in the saturated dimension. The pillagers make it impossible to explore and enjoy the environments, add some explanation or something for what the "soul" enchantments are, etc.

Bro-Omg56977 commented 2 days ago

Yikes, thats not supposed to happen...

personally, i've never had this happen to me during testing, but i'm sure it's because i didnt wait long enough for the event to fire or something. yes, it's a jojo reference [insert skull emoji here] there's a surprising amount of references in saturated my excuse is that i never stated anywhere that the datapack is vanilla friendly / vanilla plus / vanilla expansion ¯_(ツ)_/¯

oh yeah, i tweaked the mob spawning in the latest updates, and a couple of other things... i just didnt fix this main bug. oops. will probably fix this soon if i can

Bro-Omg56977 commented 2 days ago

quick update on this: im not exactly sure if this is the issue you're having, but it should be noted that i don't really recommend using commands to get to saturated if you're already in the void. kinda confusing, but leaving the void runs a function that stops the events from happening for example: if you accidentally enter the void when you didn't mean to, and then run a command like "execute in bro:saturated run tp @s ~ ~ ~" to get back to saturated instead of the way you're ment to, then that breaks some things, as function "bro:teleport/lim_to_sat" never fires, making the player never gets the tag "bropresentinvoid" removed, and the score "sat.invoid" never gets reset, essentially making the pack think you're still in the void i can probably fix this via adding a predicate to check if the player is inside the proper dimension

for a temporary fix, try putting this in chat: "/tag @s remove bropresentinvoid"

Bro-Omg56977 commented 1 day ago

released a new version with the potential fix to the issue. will leave this open incase someone else also gets the problem