search

BroadbandForum / obuspa

OB-USP-AGENT is a system daemon providing a User Services Platform (USP) Agent. https://github.com/BroadbandForum/obuspa/wiki
BSD 3-Clause "New" or "Revised" License
93 stars 62 forks source link

Set request with invalid parameter returns error msg instead of SetResp #114

Open Saravana1088 opened 3 weeks ago

Saravana1088 commented 3 weeks ago

Hello,

I am using obuspa 9.0.0. While running usp_conformance_1_20 test, receives the "set" request with an invalid parameter and returns an "error" message instead of a SetResp with an UpdatedObjectResults element and other associated elements, as described in the Test Metrics section of the test.

When I look into the code there is a difference in handling group set for allow_partial true and false cases. In the handle_set.c file, for allow_partial true in case of failure SetResp is framed with the OperationFailure message. But for allow_partial false error message is framed instead of SetResp.

PopulateSetResp_OperFailure() is the api called in case of allow_partial true and CreateErrRespFromFailedSetParams() is called in case of allow_partial false.

Please clarify whether the latest amendment test case the USP 1.3 specification, and specifically requirement R-SET.2a

holme-r commented 3 weeks ago

You are correct. This test has recently changed from requiring an Error response to requiring a SetResponse, and OBUSPA has not changed to the new behaviour yet. I have opened a ticket to fix this issue.

Saravana1088 commented 3 weeks ago

Thanks for the confirmation.