search

BroadbandForum / obuspa

OB-USP-AGENT is a system daemon providing a User Services Platform (USP) Agent. https://github.com/BroadbandForum/obuspa/wiki
BSD 3-Clause "New" or "Revised" License
93 stars 62 forks source link

obuspa sending subscribe packet again after receiving suback with Unspecified error(128) #115

Open Saravana1088 opened 2 weeks ago

Saravana1088 commented 2 weeks ago

Hello,

While running CDRouter USP Conformance mandatory test in obuspa 9.0.0, usp_conformance_11_11 case failed.

The DUT sends a SUBSCRIBE packet to which the controller sends a Suback with "Unspecified error (128)". According to R-MQTT.17 of the USP Specification, the DUT should send no more PUBLISH packets once the SUBSCRIBE has failed.

Immediately after the Suback is received, the DUT sends an MQTT packet containing SUBSCRIBE, PUBLISH, & PUBLISH control messages. The DUT should not be sending any of these packets, since the SUBSCRIBE has already failed. Additionally, it seems odd for the DUT to send a PUBLISH control message in the same packet with a SUBSCRIBE since it has not received a successful SUBACK response yet.

Because of this behavior the test case got failed. I have confirmed the same behavior with the plain obuspa-9.0.0 code without vendor changes.

Attached the CDRouter logs here usp_conformance_11_11_failure_log.txt

Kindly confirm if this is an obuspa issue in latest 9.0.0 code.

holme-r commented 2 weeks ago

This is an issue in OBUSPA. We have opened a ticket and have started work on a fix.

Saravana1088 commented 1 week ago

Thanks. Could you please let me know whether the fix can be available in 9.0.4.

holme-r commented 1 week ago

I expect a fix to be available in 9.0.4, which should be available in about a month's time. That said, the issue is that OBUSPA sends PUBLISH frames before receiving any successful SUBACK. This behavior is unlikely to cause problems in practice.

Saravana1088 commented 1 week ago

Got it. Thanks!