search

Broadcom / bdc-walkthrough

An Angular Material library for displaying walk-through pop-ups and dialogs using a declarative way.
MIT License
73 stars 17 forks source link

broke with Angular Material 17 #28

Open Shadow5084 opened 11 months ago

Shadow5084 commented 11 months ago

When using Angular Material 17 I get the following error message:

./node_modules/bdc-walkthrough/fesm2020/bdc-walkthrough.mjs:584:26-38 - Error: export '_MatMenuBase' (imported as '_MatMenuBase') was not found in '@angular/material/menu' (possible exports: MAT_MENU_CONTENT, MAT_MENU_DEFAULT_OPTIONS, MAT_MENU_PANEL, MAT_MENU_SCROLL_STRATEGY, MAT_MENU_SCROLL_STRATEGY_FACTORY_PROVIDER, MENU_PANEL_TOP_PADDING, MatMenu, MatMenuContent, MatMenuItem, MatMenuModule, MatMenuTrigger, fadeInItems, matMenuAnimations, transformMenu)

./node_modules/bdc-walkthrough/fesm2020/bdc-walkthrough.mjs:612:26-38 - Error: export '_MatMenuBase' (imported as '_MatMenuBase') was not found in '@angular/material/menu' (possible exports: MAT_MENU_CONTENT, MAT_MENU_DEFAULT_OPTIONS, MAT_MENU_PANEL, MAT_MENU_SCROLL_STRATEGY, MAT_MENU_SCROLL_STRATEGY_FACTORY_PROVIDER, MENU_PANEL_TOP_PADDING, MatMenu, MatMenuContent, MatMenuItem, MatMenuModule, MatMenuTrigger, fadeInItems, matMenuAnimations, transformMenu)

hakimio commented 11 months ago

The _MatMenuBase class import should be replaced with MatMenu to fix this. It's a very simple fix. _MatMenuBase usage in tutorial-trigger.directive.ts.

@amir-leshem-broadcom

davideas commented 10 months ago

So, the only solution is to revert to Angular Material 16 or delete this library from our code? (Here the guy must maintain his library up to date if want we use it...)

hakimio commented 10 months ago

You can also try to set skipLibCheck in tsconfig or just fork the library and fix the broken type import in your version.

davideas commented 10 months ago

For now I manually updated node_modules/bdc-walkthrough/fesm2020/bdc-walkthrough.mjs (find/replace _MatMenuBase -> MatMenu). It works until next folder cleaning.

hakimio commented 10 months ago

@davideas you can also use patch-package to make your npm "monkey patch" permanent.

hakimio commented 4 months ago

Fixed in v1.2.3.